Summary: | Regression(r199039): Possible crash under NetworkSocketStream::didFailSocketStream() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, rniwa, webkit-bug-importer, wilander | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2017-07-14 13:42:44 PDT
Created attachment 315481 [details]
Patch
Comment on attachment 315481 [details] Patch Attachment 315481 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4121474 New failing tests: security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html Created attachment 315487 [details]
Archive of layout-test-results from ews102 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 315481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315481&action=review r=me > Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:92 > + }); Wow! Nice catch. The 'mac' test failure doesn't seem likely to be related to this patch. (In reply to Brent Fulgham from comment #6) > The 'mac' test failure doesn't seem likely to be related to this patch. Indeed, the test is currently failing on the non-EWS bots. The tree is red. Comment on attachment 315481 [details] Patch Clearing flags on attachment: 315481 Committed r219525: <http://trac.webkit.org/changeset/219525> All reviewed patches have been landed. Closing bug. Comment on attachment 315481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315481&action=review >> Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:92 >> + }); > > Wow! Nice catch. Can m_client get zeroed out in between? Comment on attachment 315481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315481&action=review >>> Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:92 >>> + }); >> >> Wow! Nice catch. > > Can m_client get zeroed out in between? m_client is a reference, not a pointer and cannot be zeroed out. |