Bug 174509

Summary:

Rename RenderStyle::fontSize() to RenderStyle::computedFontPixelSize()

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, jonlee, simon.fraser, thorton, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+
Patch for committing	none
Patch for committing	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none

Myles C. Maxfield

Reported 2017-07-14 10:23:33 PDT

Rename RenderStyle::fontSize() to RenderStyle::computedFontPixelSize()

Attachments
Patch (18.48 KB, patch) 2017-07-14 10:27 PDT, Myles C. Maxfield	simon.fraser: review+	Details Formatted Diff Diff
Patch for committing (25.48 KB, patch) 2017-07-15 09:57 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (25.48 KB, patch) 2017-07-15 11:23 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-elcapitan (1.82 MB, application/zip) 2017-07-15 12:45 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (977.04 KB, application/zip) 2017-07-15 12:54 PDT, Build Bot	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2017-07-14 10:27:27 PDT

Created attachment 315441 [details] Patch

Myles C. Maxfield

Comment 2 2017-07-15 09:57:41 PDT

Created attachment 315552 [details] Patch for committing

Myles C. Maxfield

Comment 3 2017-07-15 11:23:29 PDT

Created attachment 315557 [details] Patch for committing

Build Bot

Comment 4 2017-07-15 12:45:14 PDT

Comment on attachment 315557 [details] Patch for committing Attachment 315557 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4126711 New failing tests: security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html

Build Bot

Comment 5 2017-07-15 12:45:15 PDT

Created attachment 315562 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-07-15 12:54:34 PDT

Comment on attachment 315557 [details] Patch for committing Attachment 315557 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4126721 New failing tests: storage/websql/execute-sql-rowsAffected.html http/tests/canvas/canvas-tainted-after-draw-image.html

Build Bot

Comment 7 2017-07-15 12:54:36 PDT

Created attachment 315563 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Myles C. Maxfield

Comment 8 2017-07-15 22:39:30 PDT

Failures are unrelated.

WebKit Commit Bot

Comment 9 2017-07-15 23:08:44 PDT

Comment on attachment 315557 [details] Patch for committing Clearing flags on attachment: 315557 Committed r219544: <http://trac.webkit.org/changeset/219544>

Note You need to log in before you can comment on or make changes to this bug.