Bug 174382

Summary: [WebCrypto] CryptoKeyECMac::Custom OpenSSL tag is actually tagged type [1]
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jiewen Tan
Reported 2017-07-11 13:30:04 PDT
In CryptoKeyECMac, we wrongly treat tagged type [1] as OpenSSL custom named curve tag. We should correct it.
Attachments
Patch (4.65 KB, patch)
2017-07-11 13:40 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-07-11 13:30:57 PDT
<rdar://problem/33244871>
Jiewen Tan
Comment 2 2017-07-11 13:40:02 PDT
Created attachment 315155 [details] Patch
Brent Fulgham
Comment 3 2017-07-11 13:45:02 PDT
Comment on attachment 315155 [details] Patch r=me, assuming the bots are happy.
Brent Fulgham
Comment 4 2017-07-11 13:45:32 PDT
(In reply to Jiewen Tan from comment #0) > In CryptoKeyECMac, we wrongly treat tagged type [1] as OpenSSL custom named > curve tag. We should correct it. So this appears to just bring our implementation in line with the spec, instead of using a custom named type internally? Seems reasonable.
Jiewen Tan
Comment 5 2017-07-11 13:57:29 PDT
(In reply to Brent Fulgham from comment #4) > (In reply to Jiewen Tan from comment #0) > > In CryptoKeyECMac, we wrongly treat tagged type [1] as OpenSSL custom named > > curve tag. We should correct it. > > So this appears to just bring our implementation in line with the spec, > instead of using a custom named type internally? Seems reasonable. Kind of. Before I didn't realize what those parts of binaries mean. Therefore, I thought it could be some custom types. But then I realized that those are tagged types.
WebKit Commit Bot
Comment 6 2017-07-11 16:11:44 PDT
Comment on attachment 315155 [details] Patch Clearing flags on attachment: 315155 Committed r219371: <http://trac.webkit.org/changeset/219371>
WebKit Commit Bot
Comment 7 2017-07-11 16:11:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.