Bug 174377

Summary: [WebRTC] Hanging under LibWebRTCMediaEndpoint::getStats
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, joepeck
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2017-07-11 11:35:38 PDT
getStats for logging is done in the main thread. It then does a synchronous call to the signaling thread. In case the signaling thread is busy, the main thread will be blocked. It might be better to post a task instead to the signaling thread so as not to block main thread.
Attachments
Patch (3.67 KB, patch)
2017-07-11 11:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-07-11 11:43:29 PDT
Created attachment 315140 [details] Patch
youenn fablet
Comment 2 2017-07-11 11:43:54 PDT
rdar://problem/32515212
youenn fablet
Comment 3 2017-07-11 11:44:52 PDT
We could contemplate to do that for all calls but getStats is the one that will usually happen most often during the calls where there might be bottleneck issues
WebKit Commit Bot
Comment 4 2017-07-11 13:46:28 PDT
Comment on attachment 315140 [details] Patch Clearing flags on attachment: 315140 Committed r219359: <http://trac.webkit.org/changeset/219359>
WebKit Commit Bot
Comment 5 2017-07-11 13:46:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.