Bug 174371

Summary: Remove unused OpenGL files
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: WebCore Misc.Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cgarcia, commit-queue, dino, graouts, kondapallykalyan, magomez, mcatanzaro, noam, zan
Priority: P2    
Version: WebKit Local Build   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Timothy Hatcher
Reported 2017-07-11 10:37:58 PDT
GLPlatformContext.cpp fails to find the EGLContext.h and GLXContext.h headers which where removed in https://trac.webkit.org/changeset/212705/webkit.
Attachments
Patch (1.62 KB, patch)
2017-07-11 10:39 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (1.62 KB, patch)
2017-07-11 10:39 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (15.77 KB, patch)
2017-07-11 12:07 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2017-07-11 10:39:09 PDT
Created attachment 315127 [details] Patch
Timothy Hatcher
Comment 2 2017-07-11 10:39:43 PDT
Created attachment 315128 [details] Patch
Michael Catanzaro
Comment 3 2017-07-11 11:57:07 PDT
Comment on attachment 315128 [details] Patch Looks like this entire file is dead code upstream. We should remove it, and you'll have to maintain it downstream if you need it. Sorry.
Michael Catanzaro
Comment 4 2017-07-11 12:07:16 PDT
Created attachment 315141 [details] Patch
Michael Catanzaro
Comment 5 2017-07-11 12:20:04 PDT
By the way, consider using the graphics code from the WPE port, or even basing your port off of the WPE port. We'd love to know why if it doesn't meet your requirements. Bug #172104 might be relevant.
Timothy Hatcher
Comment 6 2017-07-11 12:43:16 PDT
(In reply to Michael Catanzaro from comment #5) > By the way, consider using the graphics code from the WPE port, or even > basing your port off of the WPE port. We'd love to know why if it doesn't > meet your requirements. > > Bug #172104 might be relevant. Yes, I am looking at WPE again now that it is upstream.
Michael Catanzaro
Comment 7 2017-07-11 12:54:24 PDT
Thanks for the review!
WebKit Commit Bot
Comment 8 2017-07-11 13:21:52 PDT
Comment on attachment 315141 [details] Patch Clearing flags on attachment: 315141 Committed r219356: <http://trac.webkit.org/changeset/219356>
WebKit Commit Bot
Comment 9 2017-07-11 13:21:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.