Bug 174368

Summary: Build broken when !ENABLE(VIDEO)
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: MediaAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, joepeck, jonlee
Priority: P2    
Version: Other   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch none

Timothy Hatcher
Reported 2017-07-11 10:15:21 PDT
There are various build failures that happen when ENABLE_VIDEO is disabled. Patch to follow.
Attachments
Patch (11.62 KB, patch)
2017-07-11 10:17 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2017-07-11 10:17:45 PDT
Created attachment 315122 [details] Patch
Alex Christensen
Comment 2 2017-07-11 10:43:26 PDT
Comment on attachment 315122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315122&action=review > Source/WebCore/testing/Internals.h:445 > #if ENABLE(VIDEO) > + Vector<String> mediaResponseSources(HTMLMediaElement&); Can we make these [Conditional=VIDEO] too? I think we're trying to move away from using the C preprocessor on IDL files.
Timothy Hatcher
Comment 3 2017-07-11 10:45:33 PDT
Comment on attachment 315122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315122&action=review >> Source/WebCore/testing/Internals.h:445 >> + Vector<String> mediaResponseSources(HTMLMediaElement&); > > Can we make these [Conditional=VIDEO] too? I think we're trying to move away from using the C preprocessor on IDL files. This isn't the IDL file. I did change Internals.idl to use [Conditional=VIDEO].
Alex Christensen
Comment 4 2017-07-11 10:46:27 PDT
Comment on attachment 315122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315122&action=review >>> Source/WebCore/testing/Internals.h:445 >>> + Vector<String> mediaResponseSources(HTMLMediaElement&); >> >> Can we make these [Conditional=VIDEO] too? I think we're trying to move away from using the C preprocessor on IDL files. > > This isn't the IDL file. I did change Internals.idl to use [Conditional=VIDEO]. Woah, you're right.
WebKit Commit Bot
Comment 5 2017-07-11 11:07:28 PDT
Comment on attachment 315122 [details] Patch Clearing flags on attachment: 315122 Committed r219343: <http://trac.webkit.org/changeset/219343>
WebKit Commit Bot
Comment 6 2017-07-11 11:07:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.