Bug 174366

Summary: Use FastAllocator in STL containers
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, darin, dbates, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Description Yusuke Suzuki 2017-07-11 09:36:20 PDT 
Use FastAllocator in STL containers
Comment 1 Yusuke Suzuki 2017-07-11 09:38:22 PDT 
Created attachment 315117 [details]
Patch
Comment 2 Sam Weinig 2017-07-11 14:11:10 PDT 
Comment on attachment 315117 [details]
Patch

rs=me when it compiles.
Comment 3 Yusuke Suzuki 2017-07-11 22:06:38 PDT 
Created attachment 315205 [details]
Patch for landing

Patch for landing
Comment 4 Yusuke Suzuki 2017-07-11 22:42:42 PDT 
Committed r219383: <http://trac.webkit.org/changeset/219383>
Comment 5 Yusuke Suzuki 2017-07-12 01:58:59 PDT 
Hmmmm, while windows EWS is green, build bot is failing.
Investigating...
Comment 6 Yusuke Suzuki 2017-07-12 02:09:22 PDT 
Reopening to attach new patch.
Comment 7 Yusuke Suzuki 2017-07-12 02:09:24 PDT 
Created attachment 315217 [details]
Patch
Comment 8 Yusuke Suzuki 2017-07-12 03:11:28 PDT 
Committed r219386: <http://trac.webkit.org/changeset/219386>
Comment 9 Darin Adler 2017-07-13 10:46:36 PDT 
Comment on attachment 315217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315217&action=review

> Source/WTF/wtf/FastMalloc.h:130
> +template<typename T, typename U> bool operator==(const FastAllocator<T>&, const FastAllocator<U>&) { return true; }
> +template<typename T, typename U> bool operator!=(const FastAllocator<T>&, const FastAllocator<U>&) { return false; }

Should have "inline" on both of these.
Comment 10 Yusuke Suzuki 2017-07-13 19:53:02 PDT 
(In reply to Darin Adler from comment #9)
> Comment on attachment 315217 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315217&action=review
> 
> > Source/WTF/wtf/FastMalloc.h:130
> > +template<typename T, typename U> bool operator==(const FastAllocator<T>&, const FastAllocator<U>&) { return true; }
> > +template<typename T, typename U> bool operator!=(const FastAllocator<T>&, const FastAllocator<U>&) { return false; }
> 
> Should have "inline" on both of these.

Oops, right. Fixed.
Thank you!
Comment 11 Yusuke Suzuki 2017-07-13 19:53:29 PDT 
Committed r219491: <http://trac.webkit.org/changeset/219491>