Bug 174366

Summary: Use FastAllocator in STL containers
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, darin, dbates, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Yusuke Suzuki
Reported 2017-07-11 09:36:20 PDT
Use FastAllocator in STL containers
Attachments
Patch (27.92 KB, patch)
2017-07-11 09:38 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.66 KB, patch)
2017-07-11 22:06 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2017-07-12 02:09 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-07-11 09:38:22 PDT
Created attachment 315117 [details] Patch
Sam Weinig
Comment 2 2017-07-11 14:11:10 PDT
Comment on attachment 315117 [details] Patch rs=me when it compiles.
Yusuke Suzuki
Comment 3 2017-07-11 22:06:38 PDT
Created attachment 315205 [details] Patch for landing Patch for landing
Yusuke Suzuki
Comment 4 2017-07-11 22:42:42 PDT
Committed r219383: <http://trac.webkit.org/changeset/219383>
Yusuke Suzuki
Comment 5 2017-07-12 01:58:59 PDT
Hmmmm, while windows EWS is green, build bot is failing. Investigating...
Yusuke Suzuki
Comment 6 2017-07-12 02:09:22 PDT
Reopening to attach new patch.
Yusuke Suzuki
Comment 7 2017-07-12 02:09:24 PDT
Created attachment 315217 [details] Patch
Yusuke Suzuki
Comment 8 2017-07-12 03:11:28 PDT
Committed r219386: <http://trac.webkit.org/changeset/219386>
Darin Adler
Comment 9 2017-07-13 10:46:36 PDT
Comment on attachment 315217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315217&action=review > Source/WTF/wtf/FastMalloc.h:130 > +template<typename T, typename U> bool operator==(const FastAllocator<T>&, const FastAllocator<U>&) { return true; } > +template<typename T, typename U> bool operator!=(const FastAllocator<T>&, const FastAllocator<U>&) { return false; } Should have "inline" on both of these.
Yusuke Suzuki
Comment 10 2017-07-13 19:53:02 PDT
(In reply to Darin Adler from comment #9) > Comment on attachment 315217 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315217&action=review > > > Source/WTF/wtf/FastMalloc.h:130 > > +template<typename T, typename U> bool operator==(const FastAllocator<T>&, const FastAllocator<U>&) { return true; } > > +template<typename T, typename U> bool operator!=(const FastAllocator<T>&, const FastAllocator<U>&) { return false; } > > Should have "inline" on both of these. Oops, right. Fixed. Thank you!
Yusuke Suzuki
Comment 11 2017-07-13 19:53:29 PDT
Committed r219491: <http://trac.webkit.org/changeset/219491>
Note You need to log in before you can comment on or make changes to this bug.