Bug 174357 – [GTK][WPE] Enable FILE_LOCK and implement lockFile and unlockFile

• Component: Platform
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

This is used by WebSQL databases.

[Carlos Garcia Campos]

Created attachment 315093 [details]
Patch

[Build Bot]

Attachment 315093 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/glib/FileSystemGlib.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Created attachment 315094 [details]
Patch

[Carlos Garcia Campos]

Created attachment 315095 [details]
Patch

[Build Bot]

Comment on attachment 315095 [details]
Patch

Attachment 315095 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4100514

New failing tests:
storage/indexeddb/modern/new-database-after-user-delete.html

[Build Bot]

Created attachment 315107 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Michael Catanzaro]

Comment on attachment 315095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315095&action=review

> Source/WebCore/platform/glib/FileSystemGlib.cpp:430
> +    return (result != -1);

I would write these without the parens.

> Source/cmake/OptionsGTK.cmake:202
> +set(glib_components gio gio-unix gobject gthread gmodule)

I was going to say you can't use gio-unix unconditionally, but I guess you actually can. I suppose gio-unix is available on Mac. OK then.

[Carlos Garcia Campos]

Committed r219384: <http://trac.webkit.org/changeset/219384>