Bug 174346

Summary: Web Inspector: Node Sidebar - Improve wording for Potential Custom Element lacking a Custom definition
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Before
none
[IMAGE] After none

Joseph Pecoraro
Reported 2017-07-10 21:40:16 PDT
Summary: Node Sidebar - Improve wording for Potential Custom Element lacking a Custom definition Test: <my-test-element></my-test-element> Steps to Reproduce: 1. Inspect the <my-test-element> in the test page 2. Show Node Details Sidebar => Element (Waiting to be upgraded) Description: - The text "Waiting to be upgraded" is poor. Any non-standard element with dashes in the name has the potential to be upgraded, but doesn't need to be. So the "waiting" here is misleading. Lets just say its detected as custom, and lacks a Custom Element definition, which helps point a little bit to `window.customElements.define` for custom element definitions.
Attachments
[PATCH] Proposed Fix (4.15 KB, patch)
2017-07-10 21:42 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Before (76.61 KB, image/png)
2017-07-10 21:42 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (76.56 KB, image/png)
2017-07-10 21:43 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-07-10 21:42:29 PDT
Created attachment 315077 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2017-07-10 21:42:45 PDT
Created attachment 315078 [details] [IMAGE] Before
Joseph Pecoraro
Comment 3 2017-07-10 21:43:00 PDT
Created attachment 315079 [details] [IMAGE] After
Matt Baker
Comment 4 2017-07-11 08:47:15 PDT
Comment on attachment 315077 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 5 2017-07-11 09:15:15 PDT
Comment on attachment 315077 [details] [PATCH] Proposed Fix Clearing flags on attachment: 315077 Committed r219333: <http://trac.webkit.org/changeset/219333>
WebKit Commit Bot
Comment 6 2017-07-11 09:15:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.