Bug 174333

Summary: Adjust unpartitioned cookie time-to-live to 48 hours
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED WONTFIX    
Severity: Normal CC: bfulgham, cdumez, ggaren, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174402
Attachments:
Description Flags
Patch cdumez: review-, cdumez: commit-queue-

Brent Fulgham
Reported 2017-07-10 16:54:22 PDT
Adjust unpartitioned cookie time-to-live from 24 to 48 hours to reduce website compatibility impact.
Attachments
Patch (2.76 KB, patch)
2017-07-10 16:56 PDT, Brent Fulgham 		cdumez: review-
cdumez: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2017-07-10 16:54:44 PDT
<rdar://problem/33164423>
Brent Fulgham
Comment 2 2017-07-10 16:56:26 PDT
Created attachment 315047 [details] Patch
Chris Dumez
Comment 3 2017-07-11 15:11:29 PDT
Comment on attachment 315047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315047&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:445 > + store->setTimeToLiveCookiePartitionFree(48_h); This is only used for testing. You need to update WebResourceLoadStatisticsStore::m_timeToLiveCookiePartitionFree's default value otherwise it won't do what you want.
Chris Dumez
Comment 4 2017-07-11 15:25:43 PDT
Comment on attachment 315047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315047&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:443 > // FIXME: These needs to match the default data member values in ResourceLoadStatistics, which is fragile. I'll fix this to make it less error prone.
Chris Dumez
Comment 5 2017-07-11 16:28:42 PDT
(In reply to Chris Dumez from comment #4) > Comment on attachment 315047 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315047&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:443 > > // FIXME: These needs to match the default data member values in ResourceLoadStatistics, which is fragile. > > I'll fix this to make it less error prone. Doing this via https://bugs.webkit.org/show_bug.cgi?id=174402.
Brent Fulgham
Comment 6 2017-07-13 15:16:51 PDT
We decided not to make this change.
Note You need to log in before you can comment on or make changes to this bug.