Summary: | [WK2] Ignore touch events that interrupt platform-driven momentum scrolling | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||
Component: | WebKit2 | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bdakin, benjamin, buildbot, cmarcelo, commit-queue, fred.wang, jamesr, luiz, megan_gardner, simon.fraser, thorton, tonikitoo | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Wenson Hsieh
2017-07-09 13:44:49 PDT
Created attachment 314957 [details]
First pass
Comment on attachment 314957 [details] First pass View in context: https://bugs.webkit.org/attachment.cgi?id=314957&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4058 > +// FIXME: Remove once -gestureRecognizer:shouldIgnoreWebTouchWithEvent: is in UIWebTouchEventsGestureRecognizer.h. Would be nice to have a radar number here. > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4067 > + NSSet<UITouch *> *webTouches = [event touchesForGestureRecognizer:gestureRecognizer]; > + for (UITouch *webTouch in webTouches) { I think "webTouches" and "webTouch" could just be "touches" and "touch". Comment on attachment 314957 [details] First pass View in context: https://bugs.webkit.org/attachment.cgi?id=314957&action=review Thanks Simon! >> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4058 >> +// FIXME: Remove once -gestureRecognizer:shouldIgnoreWebTouchWithEvent: is in UIWebTouchEventsGestureRecognizer.h. > > Would be nice to have a radar number here. 👍 included a radar here. >> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4067 >> + for (UITouch *webTouch in webTouches) { > > I think "webTouches" and "webTouch" could just be "touches" and "touch". Done. Created attachment 315008 [details]
Patch for landing
Comment on attachment 315008 [details] Patch for landing Clearing flags on attachment: 315008 Committed r219310: <http://trac.webkit.org/changeset/219310> Created attachment 315073 [details]
Address post-review feedback
Created attachment 315076 [details]
Address post-review feedback
Comment on attachment 315076 [details] Address post-review feedback Clearing flags on attachment: 315076 Committed r219340: <http://trac.webkit.org/changeset/219340> |