Bug 174296

Summary: [JSC] Drop LineNumberAdder since we no longer treat <LF><CR> (not <CR><LF>) as one line terminator
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, darin, keith_miller, mark.lam, msaboff, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170810    
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2017-07-09 00:30:43 PDT
[JSC] Drop LineNumberAdder since we no longer treat <LF><CR> (not <CR><LF>) as one line terminator
Attachments
Patch (6.26 KB, patch)
2017-07-09 00:34 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-07-09 00:34:11 PDT
Created attachment 314941 [details] Patch
Mark Lam
Comment 2 2017-07-09 06:49:28 PDT
Comment on attachment 314941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314941&action=review r=me. Thanks for fixing this. Can you add a test case that covers this? Obviously, the need for this patch is not covered by existing tests or we would have seen it when the change of treatment of /n/r was added. > Source/JavaScriptCore/ChangeLog:10 > + <LF><CR> to <LF><LF>, we still needed to incrase line number by only one. typo: /incrase/increase/.
Yusuke Suzuki
Comment 3 2017-07-09 19:32:38 PDT
Comment on attachment 314941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314941&action=review Ah, this is already covered in template-literal-line-terminators.js. That's why r219263 changes that test. This patch itself does not change any logic. It just drops unnecessary LineNumberAdder. The logic of LineNumberAdder is changed in r219263. >> Source/JavaScriptCore/ChangeLog:10 >> + <LF><CR> to <LF><LF>, we still needed to incrase line number by only one. > > typo: /incrase/increase/. Oops, fixed.
Yusuke Suzuki
Comment 4 2017-07-09 19:35:01 PDT
Committed r219285: <http://trac.webkit.org/changeset/219285>
Note You need to log in before you can comment on or make changes to this bug.