| Summary: | [JSC] Drop LineNumberAdder since we no longer treat <LF><CR> (not <CR><LF>) as one line terminator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, darin, keith_miller, mark.lam, msaboff, saam, sam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 170810 | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2017-07-09 00:30:43 PDT
Created attachment 314941 [details]
Patch
Comment on attachment 314941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314941&action=review r=me. Thanks for fixing this. Can you add a test case that covers this? Obviously, the need for this patch is not covered by existing tests or we would have seen it when the change of treatment of /n/r was added. > Source/JavaScriptCore/ChangeLog:10 > + <LF><CR> to <LF><LF>, we still needed to incrase line number by only one. typo: /incrase/increase/. Comment on attachment 314941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314941&action=review Ah, this is already covered in template-literal-line-terminators.js. That's why r219263 changes that test. This patch itself does not change any logic. It just drops unnecessary LineNumberAdder. The logic of LineNumberAdder is changed in r219263. >> Source/JavaScriptCore/ChangeLog:10 >> + <LF><CR> to <LF><LF>, we still needed to incrase line number by only one. > > typo: /incrase/increase/. Oops, fixed. Committed r219285: <http://trac.webkit.org/changeset/219285> |