Bug 174295

Summary: Block of text is missing in iBooks sample books.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2017-07-08 22:33:50 PDT 
rdar://problem/32955620
Comment 1 zalan 2017-07-08 22:36:06 PDT 
Created attachment 314938 [details]
Patch
Comment 2 zalan 2017-07-09 16:33:32 PDT 
Created attachment 314958 [details]
Patch
Comment 3 Antti Koivisto 2017-07-10 01:48:20 PDT 
Comment on attachment 314958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314958&action=review

> Source/WebCore/rendering/SimpleLineLayoutResolver.cpp:169
> +    // Did we miss the line?
> +    if (y < bottom && !lastIndexCandidate) {
> +        ASSERT_NOT_REACHED();
> +        return lineIndexCandidate;
>      }

Should turn this into pure assert post-branch.
Comment 4 zalan 2017-07-10 08:05:27 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 314958 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314958&action=review
> 
> > Source/WebCore/rendering/SimpleLineLayoutResolver.cpp:169
> > +    // Did we miss the line?
> > +    if (y < bottom && !lastIndexCandidate) {
> > +        ASSERT_NOT_REACHED();
> > +        return lineIndexCandidate;
> >      }
> 
> Should turn this into pure assert post-branch.
Indeed.
Comment 5 zalan 2017-07-10 08:25:31 PDT 
Created attachment 314981 [details]
Patch
Comment 6 WebKit Commit Bot 2017-07-10 09:03:06 PDT 
Comment on attachment 314981 [details]
Patch

Clearing flags on attachment: 314981

Committed r219291: <http://trac.webkit.org/changeset/219291>
Comment 7 WebKit Commit Bot 2017-07-10 09:03:08 PDT 
All reviewed patches have been landed.  Closing bug.