Bug 174249

Summary:

[WPE] WebGL2 support

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, dbates, dino, graouts, kondapallykalyan, noam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

172104, 174251

Bug Blocks:

Attachments:

Description	Flags
WIP patch	none
Patch	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	achristensen: review+

Zan Dobersek

Reported 2017-07-07 03:37:07 PDT

WPE-specific counterpart to bug #166536.

Attachments
WIP patch (4.96 KB, patch) 2017-07-16 23:36 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (8.35 KB, patch) 2017-07-20 10:48 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (15.50 MB, application/zip) 2017-07-20 15:10 PDT, Build Bot	no flags	Details
Patch (7.94 KB, patch) 2017-07-24 09:23 PDT, Zan Dobersek	achristensen: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2017-07-16 23:36:29 PDT

Created attachment 315642 [details] WIP patch

Zan Dobersek

Comment 2 2017-07-20 10:48:41 PDT

Created attachment 315999 [details] Patch

Build Bot

Comment 3 2017-07-20 15:10:38 PDT

Comment on attachment 315999 [details] Patch Attachment 315999 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4157500 New failing tests: imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html

Build Bot

Comment 4 2017-07-20 15:10:40 PDT

Created attachment 316031 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Alex Christensen

Comment 5 2017-07-21 14:16:01 PDT

Comment on attachment 315999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315999&action=review > Source/WebCore/ChangeLog:31 > + SH_WEBGL2_SPEC in case of OpenGL ES 3.0 library, or SH_WEBGL3_SPEC in case of 3.1. WebGL3? What is this?

Zan Dobersek

Comment 6 2017-07-24 07:17:44 PDT

Comment on attachment 315999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315999&action=review >> Source/WebCore/ChangeLog:31 >> + SH_WEBGL2_SPEC in case of OpenGL ES 3.0 library, or SH_WEBGL3_SPEC in case of 3.1. > > WebGL3? What is this? That's an error on my side. I thought this affects the output of the input shader, but in fact the SH_WEBGL3_SPEC value is a placeholder enum entry for the future (if any?) WebGL spec, and it only affects how the passed-in shader is translated, So for WebGL2 SH_WEBGL2_SPEC should be passed in, regardless of the underyling OpenGL ES version. I'll have to update this patch and put it up for another review.

Zan Dobersek

Comment 7 2017-07-24 09:23:15 PDT

Created attachment 316295 [details] Patch

Alex Christensen

Comment 8 2017-07-24 11:18:19 PDT

Comment on attachment 316295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316295&action=review > Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp:83 > return 0; these should be nullptr.

Zan Dobersek

Comment 9 2017-07-26 01:26:11 PDT

Committed r219910: <http://trac.webkit.org/changeset/219910>

Note You need to log in before you can comment on or make changes to this bug.