Bug 174238

Summary: [WebIDL] Move plugin object customization into the generator
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2017-07-06 20:47:43 PDT
[WebIDL] Move plugin object customization into the generator
Attachments
Patch (88.05 KB, patch)
2017-07-06 20:48 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (88.89 KB, patch)
2017-07-06 22:17 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (88.99 KB, patch)
2017-07-07 06:43 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (89.41 KB, patch)
2017-07-07 13:21 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-07-06 20:48:22 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2017-07-06 22:17:22 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2017-07-07 06:43:41 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2017-07-07 13:21:07 PDT
Created attachment 314869 [details] Patch
Chris Dumez
Comment 5 2017-07-09 10:17:06 PDT
Comment on attachment 314869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314869&action=review > Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:358 > +bool JSCSSStyleDeclaration::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot) This is more custom code now. > Source/WebCore/bindings/js/JSLocationCustom.cpp:126 > +bool JSLocation::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot) This is more custom code now.
Sam Weinig
Comment 6 2017-07-09 18:34:56 PDT
(In reply to Chris Dumez from comment #5) > Comment on attachment 314869 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314869&action=review > > > Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:358 > > +bool JSCSSStyleDeclaration::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot) > > This is more custom code now. > > > Source/WebCore/bindings/js/JSLocationCustom.cpp:126 > > +bool JSLocation::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot) > > This is more custom code now. It is a tiny bit more code, but it allows us to get rid of having two ways to override put, which is confusing and error prone. In reality, Location is custom enough that having the generator do things it doesn't expect is probably worse.
WebKit Commit Bot
Comment 7 2017-07-10 11:27:30 PDT
Comment on attachment 314869 [details] Patch Clearing flags on attachment: 314869 Committed r219302: <http://trac.webkit.org/changeset/219302>
WebKit Commit Bot
Comment 8 2017-07-10 11:27:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.