Summary: | [WebIDL] Move plugin object customization into the generator | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, darin | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sam Weinig
2017-07-06 20:47:43 PDT
Created attachment 314807 [details]
Patch
Created attachment 314818 [details]
Patch
Created attachment 314837 [details]
Patch
Created attachment 314869 [details]
Patch
Comment on attachment 314869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314869&action=review > Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:358 > +bool JSCSSStyleDeclaration::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot) This is more custom code now. > Source/WebCore/bindings/js/JSLocationCustom.cpp:126 > +bool JSLocation::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot) This is more custom code now. (In reply to Chris Dumez from comment #5) > Comment on attachment 314869 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314869&action=review > > > Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:358 > > +bool JSCSSStyleDeclaration::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot) > > This is more custom code now. > > > Source/WebCore/bindings/js/JSLocationCustom.cpp:126 > > +bool JSLocation::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot) > > This is more custom code now. It is a tiny bit more code, but it allows us to get rid of having two ways to override put, which is confusing and error prone. In reality, Location is custom enough that having the generator do things it doesn't expect is probably worse. Comment on attachment 314869 [details] Patch Clearing flags on attachment: 314869 Committed r219302: <http://trac.webkit.org/changeset/219302> All reviewed patches have been landed. Closing bug. |