Bug 174226

Summary: Drop unused ResourceLoadStatistics members
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, dbates, ggaren, japhet, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2017-07-06 16:03:41 PDT 
Drop unused ResourceLoadStatistics members.
Comment 1 Chris Dumez 2017-07-06 16:10:08 PDT 
Created attachment 314769 [details]
Patch
Comment 2 Chris Dumez 2017-07-06 16:38:49 PDT 
Created attachment 314778 [details]
Patch
Comment 3 Chris Dumez 2017-07-06 16:54:45 PDT 
Created attachment 314779 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2017-07-06 19:19:38 PDT 
<rdar://problem/33172845>
Comment 5 Brent Fulgham 2017-07-06 19:21:30 PDT 
Comment on attachment 314779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314779&action=review

r=me

> Source/WebCore/loader/ResourceLoadObserver.cpp:114
> +    // FIXME: targetStatistics.dataRecordsRemoved is always 0 in WebCore as it gets populated in the UIProcess.

Why not just get rid of this entirely?
Comment 6 Chris Dumez 2017-07-06 19:22:13 PDT 
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 314779 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314779&action=review
> 
> r=me
> 
> > Source/WebCore/loader/ResourceLoadObserver.cpp:114
> > +    // FIXME: targetStatistics.dataRecordsRemoved is always 0 in WebCore as it gets populated in the UIProcess.
> 
> Why not just get rid of this entirely?

Planning to do this in a follow up for clarity as it was not strictly related.
Comment 7 Chris Dumez 2017-07-06 19:44:20 PDT 
Comment on attachment 314779 [details]
Patch

Clearing flags on attachment: 314779

Committed r219231: <http://trac.webkit.org/changeset/219231>
Comment 8 Chris Dumez 2017-07-06 19:44:22 PDT 
All reviewed patches have been landed.  Closing bug.