Bug 174226

Summary: Drop unused ResourceLoadStatistics members
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, dbates, ggaren, japhet, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-07-06 16:03:41 PDT
Drop unused ResourceLoadStatistics members.
Attachments
Patch (31.21 KB, patch)
2017-07-06 16:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (33.92 KB, patch)
2017-07-06 16:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (33.99 KB, patch)
2017-07-06 16:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-07-06 16:10:08 PDT
Created attachment 314769 [details] Patch
Chris Dumez
Comment 2 2017-07-06 16:38:49 PDT
Created attachment 314778 [details] Patch
Chris Dumez
Comment 3 2017-07-06 16:54:45 PDT
Created attachment 314779 [details] Patch
Radar WebKit Bug Importer
Comment 4 2017-07-06 19:19:38 PDT
<rdar://problem/33172845>
Brent Fulgham
Comment 5 2017-07-06 19:21:30 PDT
Comment on attachment 314779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314779&action=review r=me > Source/WebCore/loader/ResourceLoadObserver.cpp:114 > + // FIXME: targetStatistics.dataRecordsRemoved is always 0 in WebCore as it gets populated in the UIProcess. Why not just get rid of this entirely?
Chris Dumez
Comment 6 2017-07-06 19:22:13 PDT
(In reply to Brent Fulgham from comment #5) > Comment on attachment 314779 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314779&action=review > > r=me > > > Source/WebCore/loader/ResourceLoadObserver.cpp:114 > > + // FIXME: targetStatistics.dataRecordsRemoved is always 0 in WebCore as it gets populated in the UIProcess. > > Why not just get rid of this entirely? Planning to do this in a follow up for clarity as it was not strictly related.
Chris Dumez
Comment 7 2017-07-06 19:44:20 PDT
Comment on attachment 314779 [details] Patch Clearing flags on attachment: 314779 Committed r219231: <http://trac.webkit.org/changeset/219231>
Chris Dumez
Comment 8 2017-07-06 19:44:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.