Bug 174221

Summary: [Win] Build precompiled header successfully with clang-cl
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 173889    
Attachments:
Description Flags
Patch to pass /FI for clang-cl builds when making precompiled headers
none
Patch to pass /FI for clang-cl builds when making precompiled headers none

Description Stephan Szabo 2017-07-06 15:27:21 PDT
Clang-cl doesn't support using /Yc without /FI and gives a warning. Without ninja we don't seem to get any pch built, with it, we seem to get one built by CL that clang-cl cannot read.
Comment 1 Stephan Szabo 2017-07-06 15:34:20 PDT
Created attachment 314764 [details]
Patch to pass /FI for clang-cl builds when making precompiled headers
Comment 2 Stephan Szabo 2017-07-06 16:24:56 PDT
Created attachment 314774 [details]
Patch to pass /FI for clang-cl builds when making precompiled headers
Comment 3 WebKit Commit Bot 2017-07-06 18:11:04 PDT
Comment on attachment 314774 [details]
Patch to pass /FI for clang-cl builds when making precompiled headers

Clearing flags on attachment: 314774

Committed r219228: <http://trac.webkit.org/changeset/219228>
Comment 4 WebKit Commit Bot 2017-07-06 18:11:05 PDT
All reviewed patches have been landed.  Closing bug.