Bug 174221

Summary: [Win] Build precompiled header successfully with clang-cl
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 173889    
Attachments:
Description Flags
Patch to pass /FI for clang-cl builds when making precompiled headers
none
Patch to pass /FI for clang-cl builds when making precompiled headers none

Stephan Szabo
Reported 2017-07-06 15:27:21 PDT
Clang-cl doesn't support using /Yc without /FI and gives a warning. Without ninja we don't seem to get any pch built, with it, we seem to get one built by CL that clang-cl cannot read.
Attachments
Patch to pass /FI for clang-cl builds when making precompiled headers (1.72 KB, patch)
2017-07-06 15:34 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Patch to pass /FI for clang-cl builds when making precompiled headers (1.72 KB, patch)
2017-07-06 16:24 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2017-07-06 15:34:20 PDT
Created attachment 314764 [details] Patch to pass /FI for clang-cl builds when making precompiled headers
Stephan Szabo
Comment 2 2017-07-06 16:24:56 PDT
Created attachment 314774 [details] Patch to pass /FI for clang-cl builds when making precompiled headers
WebKit Commit Bot
Comment 3 2017-07-06 18:11:04 PDT
Comment on attachment 314774 [details] Patch to pass /FI for clang-cl builds when making precompiled headers Clearing flags on attachment: 314774 Committed r219228: <http://trac.webkit.org/changeset/219228>
WebKit Commit Bot
Comment 4 2017-07-06 18:11:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.