Bug 174209

Summary:

Web Inspector: Highlight matching canvas element when hovering contexts in the Resources tab

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, joepeck

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

138941

Bug Blocks:

174279

Attachments:

Description	Flags
Patch	joepeck: review+
Patch	none

Description Devin Rousso 2017-07-06 10:19:33 PDT

This would be useful for quickly finding the right canvas to inspect.

Comment 1 Devin Rousso 2017-07-06 10:25:26 PDT

Created attachment 314734 [details]
Patch

Comment 2 Joseph Pecoraro 2017-07-06 10:53:23 PDT

Comment on attachment 314734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314734&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:43
> +        this.element.addEventListener("mouseover", this._handleMouseover.bind(this));
> +        this.element.addEventListener("mouseout", this._handleMouseout.bind(this));

Seems we have more occurrences of "handleMouseOver" than "handleMouseover". Same with `MouseOut`.

Comment 3 Devin Rousso 2017-07-06 13:13:14 PDT

Created attachment 314749 [details]
Patch

Comment 4 WebKit Commit Bot 2017-07-06 13:51:23 PDT

Comment on attachment 314749 [details]
Patch

Clearing flags on attachment: 314749

Committed r219214: <http://trac.webkit.org/changeset/219214>

Comment 5 WebKit Commit Bot 2017-07-06 13:51:24 PDT

All reviewed patches have been landed.  Closing bug.