Bug 174200 – setupgitclone.py needs to be updated in order to work with Perl 5.26.0+

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alicia Boya García]

Perl 5.26.0 introduces an important backwards incompatible change: the current working directory is no longer part of `@INC` by default.

http://blogs.perl.org/users/sawyer_x/2017/05/perl-5260-is-now-available.html

This makes invocations like this fail:

perl -e "use VCSUtils; ..."

In order to work with new versions of Perl, the current working directory must be added to the include path before running the `use` instruction, e.g:

perl -e "use lib '.'; use VCSUtils; ..."

setupgitclone.py has two of these invocations.

[Alicia Boya García]

Created attachment 314722 [details]
Patch

[Michael Catanzaro]

Comment on attachment 314722 [details]
Patch

There's always the risk this will break all our bots, but it looks fine. Remember to set cq? to request commit in the future.

[WebKit Commit Bot]

Comment on attachment 314722 [details]
Patch

Clearing flags on attachment: 314722

Committed r219197: <http://trac.webkit.org/changeset/219197>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Konstantin Tokarev]

FWIW, I would use "-I." argument

[Alicia Boya García]

+1 to using -I.