RESOLVED FIXED174200
setupgitclone.py needs to be updated in order to work with Perl 5.26.0+ 
https://bugs.webkit.org/show_bug.cgi?id=174200
Summary setupgitclone.py needs to be updated in order to work with Perl 5.26.0+
Alicia Boya García
Reported 2017-07-06 03:39:15 PDT
Perl 5.26.0 introduces an important backwards incompatible change: the current working directory is no longer part of `@INC` by default. http://blogs.perl.org/users/sawyer_x/2017/05/perl-5260-is-now-available.html This makes invocations like this fail: perl -e "use VCSUtils; ..." In order to work with new versions of Perl, the current working directory must be added to the include path before running the `use` instruction, e.g: perl -e "use lib '.'; use VCSUtils; ..." setupgitclone.py has two of these invocations.
Attachments
Patch (1.94 KB, patch)
2017-07-06 07:57 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2017-07-06 07:57:51 PDT
Created attachment 314722 [details] Patch
Michael Catanzaro
Comment 2 2017-07-06 08:09:45 PDT
Comment on attachment 314722 [details] Patch There's always the risk this will break all our bots, but it looks fine. Remember to set cq? to request commit in the future.
WebKit Commit Bot
Comment 3 2017-07-06 08:37:46 PDT
Comment on attachment 314722 [details] Patch Clearing flags on attachment: 314722 Committed r219197: <http://trac.webkit.org/changeset/219197>
WebKit Commit Bot
Comment 4 2017-07-06 08:37:48 PDT
All reviewed patches have been landed. Closing bug.
Konstantin Tokarev
Comment 5 2017-07-06 09:24:42 PDT
FWIW, I would use "-I." argument
Alicia Boya García
Comment 6 2017-07-06 09:41:25 PDT
+1 to using -I.
Note You need to log in before you can comment on or make changes to this bug.