Bug 174200 - setupgitclone.py needs to be updated in order to work with Perl 5.26.0+
Summary: setupgitclone.py needs to be updated in order to work with Perl 5.26.0+
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2017-07-06 03:39 PDT by Alicia Boya García
Modified: 2017-07-06 09:41 PDT (History)
8 users (show)

See Also:

Patch (1.94 KB, patch)
2017-07-06 07:57 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2017-07-06 03:39:15 PDT
Perl 5.26.0 introduces an important backwards incompatible change: the current working directory is no longer part of `@INC` by default.


This makes invocations like this fail:

perl -e "use VCSUtils; ..."

In order to work with new versions of Perl, the current working directory must be added to the include path before running the `use` instruction, e.g:

perl -e "use lib '.'; use VCSUtils; ..."

setupgitclone.py has two of these invocations.
Comment 1 Alicia Boya García 2017-07-06 07:57:51 PDT
Created attachment 314722 [details]
Comment 2 Michael Catanzaro 2017-07-06 08:09:45 PDT
Comment on attachment 314722 [details]

There's always the risk this will break all our bots, but it looks fine. Remember to set cq? to request commit in the future.
Comment 3 WebKit Commit Bot 2017-07-06 08:37:46 PDT
Comment on attachment 314722 [details]

Clearing flags on attachment: 314722

Committed r219197: <http://trac.webkit.org/changeset/219197>
Comment 4 WebKit Commit Bot 2017-07-06 08:37:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Konstantin Tokarev 2017-07-06 09:24:42 PDT
FWIW, I would use "-I." argument
Comment 6 Alicia Boya García 2017-07-06 09:41:25 PDT
+1 to using -I.