Bug 174186

Summary:

[WebIDL] Remove custom bindings for WebGL code dealing with WebGL extensions

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, darin, dino

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sam Weinig 2017-07-05 16:56:41 PDT

[WebIDL] Remove custom bindings for WebGL code dealing with WebGL extensions

Comment 1 Sam Weinig 2017-07-05 17:13:04 PDT

Created attachment 314670 [details]
Patch

Comment 2 Alex Christensen 2017-07-06 17:47:10 PDT

Comment on attachment 314670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314670&action=review

> Source/WebCore/bindings/IDLTypes.h:56
> +#if ENABLE(WEBGL)
> +class WebGLExtension;
> +#endif

It doesn't hurt to forward declare a class outside of guards, does it?

Comment 3 WebKit Commit Bot 2017-07-06 18:16:10 PDT

Comment on attachment 314670 [details]
Patch

Clearing flags on attachment: 314670

Committed r219229: <http://trac.webkit.org/changeset/219229>

Comment 4 WebKit Commit Bot 2017-07-06 18:16:12 PDT

All reviewed patches have been landed.  Closing bug.