Bug 174172

Summary: [Curl] Don't start downloading more than once for same request
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: WebKit Misc.Assignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
FIX none

Basuke Suzuki
Reported 2017-07-05 13:20:21 PDT
CurlDownload tries to start downloading job twice for same Curl Handle, but callback is called for each handle. RefCount become wrong after complete.
Attachments
FIX (1.14 KB, patch)
2017-07-14 14:58 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-07-14 14:58:36 PDT
Created attachment 315494 [details] FIX WebDownload calls start() from init(), but start() should be called from the owner of WebDownload.
WebKit Commit Bot
Comment 2 2017-07-14 16:03:16 PDT
Comment on attachment 315494 [details] FIX Clearing flags on attachment: 315494 Committed r219532: <http://trac.webkit.org/changeset/219532>
WebKit Commit Bot
Comment 3 2017-07-14 16:03:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.