Bug 174162

Summary: Rename source directory and project files from WebKit to WebKitLegacy
Product: WebKit Reporter: Matthew Hanson <matthew_hanson>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bdakin, calvaris, clopez, csaavedra, guijemont, jdiggs, jfernandez, lforschler, magomez, mcatanzaro, mitz, rego, webkit-bug-importer, yoon
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174164    
Attachments:
Description Flags
Rename + tools/configurations updates + project file updates none

Description Matthew Hanson 2017-07-05 10:18:49 PDT 
The WebKitLegacy framework is confusingly dubbed "WebKit" in source code and project files. This bug tracks the rename of these source directories, project files, and references to them. My proposal for this work encompasses four distinct tasks:

1. Rename the source directory
The proposed rename is: Source/WebKit/ => Source/WebKitLegacy/

2. Rename relevant Makefiles, tools, configurations, etc...
This must be done in conjunction with (1). If done in separate commits, the commits should be contiguous.

3. Rename the Xcode project
The proposed rename is: Source/WebKit/WebKit.xcodeproj => Source/WebKitLegacy/WebKitLegacy.xcodeproj

4. Rename the Visual Studio project
The proposed rename is: Source/WebKit/WebKit.vcxproj => Source/WebKitLegacy/WebKitLegacy.vcxproj
Comment 1 Radar WebKit Bug Importer 2017-07-05 10:48:04 PDT 
<rdar://problem/33137594>
Comment 2 Matthew Hanson 2017-07-05 11:30:35 PDT 
Created attachment 314625 [details]
Rename + tools/configurations updates + project file updates

This patch contains the rename, the tools/configuration updates, and the project file updates for both Xcode and Visual Studio.
Comment 3 Matthew Hanson 2017-07-10 10:53:41 PDT 
I've added the Igalia folks to solicit their help in validating the GTK builds + tests.
Comment 4 Michael Catanzaro 2017-07-10 12:58:45 PDT 
The GTK EWS failed on an unrelated problem we had when the patch was uploaded five days ago. I'll look closer at this soon, but it's possible it would pass if the patch is just reuploaded.
Comment 5 Matthew Hanson 2017-07-10 13:33:55 PDT 
(In reply to Michael Catanzaro from comment #4)
> The GTK EWS failed on an unrelated problem we had when the patch was
> uploaded five days ago. I'll look closer at this soon, but it's possible it
> would pass if the patch is just reuploaded.

Agreed.

Because most of the patch is renaming individual files, I'll need to re-generate the patch first. I'm going to try again this afternoon.