Summary: | [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | buildbot, commit-queue, darin, jlewis3, mark.lam, saam, sam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2017-07-04 21:41:15 PDT
Created attachment 314598 [details]
Patch
Attachment 314598 [details] did not pass style-queue:
ERROR: Source/WebCore/accessibility/AXObjectCache.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 145 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 314598 [details]
Patch
r=me
Comment on attachment 314598 [details]
Patch
Thank you!
Comment on attachment 314598 [details] Patch Clearing flags on attachment: 314598 Committed r219178: <http://trac.webkit.org/changeset/219178> All reviewed patches have been landed. Closing bug. This revision caused an API failure on all Debug testers. The test failing is: StringBuilderTest.ToAtomicStringOnEmpty https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/2054/steps/run-api-tests/logs/stdio https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/2060 This is causing the trees to stay on a consistent failure. Reverted r219178 for reason: This caused a consistent failure with the API test StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers. Committed r219199: <http://trac.webkit.org/changeset/219199> (In reply to Matt Lewis from comment #7) > This revision caused an API failure on all Debug testers. The test failing > is: > StringBuilderTest.ToAtomicStringOnEmpty > > https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/2054/steps/run-api- > tests/logs/stdio > https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/2060 > > This is causing the trees to stay on a consistent failure. Thanks! This is because of TestWTF's bug. It does not call AtomicString::init() while it uses AtomicString. I'll add it and land it again. Committed r219237: <http://trac.webkit.org/changeset/219237> |