Bug 174147

Summary: Style sharing check for fullscreen element seems bogus.
Product: WebKit Reporter: Emilio Cobos Álvarez <ecobos>
Component: CSSAssignee: Emilio Cobos Álvarez <ecobos>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: buildbot, koivisto, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Emilio Cobos Álvarez
Reported 2017-07-04 21:06:55 PDT
Seems like a typo... I'm not sure how to add a test for something like uses the fullscreen API (plus, style sharing seems somewhat obscure to test on isolation). But happy to do so if there's an straight-forward way to do it.
Attachments
Patch (1.56 KB, patch)
2017-07-04 21:08 PDT, Emilio Cobos Álvarez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emilio Cobos Álvarez
Comment 1 2017-07-04 21:08:54 PDT
Created attachment 314596 [details] Patch
Build Bot
Comment 2 2017-07-04 21:11:35 PDT
Attachment 314596 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Emilio Cobos Álvarez
Comment 3 2017-07-04 22:10:40 PDT
Oh, I'd swear I had seen that typo before. It was indeed the first patch I tried to submit to WebKit! This is a dupe of https://bugs.webkit.org/show_bug.cgi?id=160196 *** This bug has been marked as a duplicate of bug 160196 ***
Note You need to log in before you can comment on or make changes to this bug.