Bug 174116

Summary: [iOS DnD] [WK2] Callout bar should reappear after dragging ends for a text selection
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, megan_gardner, rniwa, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Guard selection UI hiding against multiple item drags. none

Wenson Hsieh
Reported 2017-07-03 19:18:17 PDT
<rdar://problem/33017845>
Attachments
Patch (6.28 KB, patch)
2017-07-03 19:41 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Guard selection UI hiding against multiple item drags. (6.48 KB, patch)
2017-07-03 19:45 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-07-03 19:41:03 PDT
Created attachment 314545 [details] Patch
Wenson Hsieh
Comment 2 2017-07-03 19:45:36 PDT
Created attachment 314546 [details] Guard selection UI hiding against multiple item drags.
Ryosuke Niwa
Comment 3 2017-07-03 19:56:34 PDT
Comment on attachment 314546 [details] Guard selection UI hiding against multiple item drags. Oh my, new code surely looks very strange :( Can we somehow fix it in UIKit before making this change?
Wenson Hsieh
Comment 4 2017-07-03 20:00:21 PDT
(In reply to Ryosuke Niwa from comment #3) > Comment on attachment 314546 [details] > Guard selection UI hiding against multiple item drags. > > Oh my, new code surely looks very strange :( Can we somehow fix it in UIKit > before making this change? That would be nice, but I preferred not to block this change on a UIKit submission as well :P Since it's just renaming (but exposing the same functionality) I'll work on a UIKit renaming tweak in parallel, and then when that's in the build, transition WebKit2 over to use the renamed methods.
WebKit Commit Bot
Comment 5 2017-07-03 21:33:24 PDT
Comment on attachment 314546 [details] Guard selection UI hiding against multiple item drags. Clearing flags on attachment: 314546 Committed r219113: <http://trac.webkit.org/changeset/219113>
WebKit Commit Bot
Comment 6 2017-07-03 21:33:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.