Bug 174103

Summary: Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Matt Rajca <mrajca>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, don.olmstead, eric.carlson, jeremyj-wk, jer.noble, jonlee, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
achristensen: review+
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 none

Matt Rajca
Reported 2017-07-03 14:04:07 PDT
When we update website policies on-demand, add/remove media element behavior restrictions to/from any existing media elements. <rdar://problem/32854043>
Attachments
Patch (26.54 KB, patch)
2017-07-03 14:19 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (22.28 KB, patch)
2017-07-03 14:46 PDT, Matt Rajca 		achristensen: review+
DetailsFormatted DiffDiff
Patch (24.10 KB, patch)
2017-07-03 15:02 PDT, Matt Rajca 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.11 MB, application/zip)
2017-07-03 16:14 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Rajca
Comment 1 2017-07-03 14:19:39 PDT
Created attachment 314517 [details] Patch
Build Bot
Comment 2 2017-07-03 14:22:02 PDT
Attachment 314517 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2836: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:805: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Matt Rajca
Comment 3 2017-07-03 14:46:13 PDT
Created attachment 314520 [details] Patch
Build Bot
Comment 4 2017-07-03 14:48:47 PDT
Attachment 314520 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2836: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:805: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 5 2017-07-03 14:53:43 PDT
Comment on attachment 314520 [details] Patch r=me. GTK needs a bool added somewhere.
Matt Rajca
Comment 6 2017-07-03 15:02:38 PDT
Created attachment 314523 [details] Patch
Build Bot
Comment 7 2017-07-03 15:04:19 PDT
Attachment 314523 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2836: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:805: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 8 2017-07-03 16:14:55 PDT
Comment on attachment 314523 [details] Patch Attachment 314523 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4047243 New failing tests: workers/bomb.html
Build Bot
Comment 9 2017-07-03 16:14:56 PDT
Created attachment 314532 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Matt Rajca
Comment 10 2017-07-03 16:21:18 PDT
http://trac.webkit.org/changeset/219106/webkit
Don Olmstead
Comment 11 2017-07-05 15:58:39 PDT
This breaks builds without ENABLE_VIDEO
Matt Rajca
Comment 12 2017-07-06 14:25:14 PDT
(In reply to Don Olmstead from comment #11) > This breaks builds without ENABLE_VIDEO Fixed, sorry about that!
Note You need to log in before you can comment on or make changes to this bug.