Bug 174102

Summary: Add better crash logging for allocation sinking phase
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rniwa, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch for landing
none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 none

Saam Barati
Reported 2017-07-03 13:38:09 PDT
Already rubber stamped by Filip.
Attachments
patch for landing (2.75 KB, patch)
2017-07-03 14:09 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.33 MB, application/zip)
2017-07-03 14:50 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-07-03 13:38:41 PDT
<rdar://problem/33112092>
Saam Barati
Comment 2 2017-07-03 14:09:10 PDT
Created attachment 314515 [details] patch for landing
Build Bot
Comment 3 2017-07-03 14:50:54 PDT
Comment on attachment 314515 [details] patch for landing Attachment 314515 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4046842 New failing tests: workers/bomb.html
Build Bot
Comment 4 2017-07-03 14:50:55 PDT
Created attachment 314521 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 5 2017-07-03 14:51:04 PDT
Comment on attachment 314515 [details] patch for landing Clearing flags on attachment: 314515 Committed r219098: <http://trac.webkit.org/changeset/219098>
WebKit Commit Bot
Comment 6 2017-07-03 14:51:06 PDT
All reviewed patches have been landed. Closing bug.
Keith Miller
Comment 7 2017-07-03 16:40:35 PDT
Comment on attachment 314515 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=314515&action=review > Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:53 > + CRASH_WITH_SECURITY_IMPLICATION_AND_INFO(line); I think the intention is to use a unique enum value from AbortReason.h otherwise it's harder for our tools to track the crashes over time. At least this is what JF wanted me to do.
Saam Barati
Comment 8 2017-07-03 18:15:30 PDT
Comment on attachment 314515 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=314515&action=review >> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:53 >> + CRASH_WITH_SECURITY_IMPLICATION_AND_INFO(line); > > I think the intention is to use a unique enum value from AbortReason.h otherwise it's harder for our tools to track the crashes over time. At least this is what JF wanted me to do. Ok, I'll add one for this. Almost certainly we'll remove this code before we add more reasons, but it's good to stick with the intention of the API
Note You need to log in before you can comment on or make changes to this bug.