Bug 174083

Summary: [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, darin, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2017-07-02 20:31:28 PDT
[WebIDL] Remove more unnecessary uses of the preprocessor in idl files
Attachments
Patch (44.50 KB, patch)
2017-07-02 20:37 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (74.24 KB, text/plain)
2017-07-06 14:27 PDT, Sam Weinig 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-07-02 20:37:59 PDT
Created attachment 314439 [details] Patch
Build Bot
Comment 2 2017-07-02 20:40:35 PDT
Attachment 314439 [details] did not pass style-queue: ERROR: Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] Total errors found: 5 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2017-07-02 20:43:05 PDT
Only 4 uses of the preprocessor for IDLs remain: - DeviceOrientationEvent has an #if defined(WTF_PLATFORM_IOS). We should see if we can merge the iOS and standards track implementations. This would require adding support for the 'absolute' property. - Document.idl has a union, RenderingContext, that has items that are conditionally supported. - CanvasRenderingContext2D.idl has a union, CanvasImageSource, that has items that are conditionally supported. - HTMLMediaElement has has a union, MediaProvider, that has items that are conditionally supported. Solving these three are more difficult, as we don't have a good model of this conditionality. We should look into extended attributes on the union members for this.
Alex Christensen
Comment 4 2017-07-03 14:20:59 PDT
Comment on attachment 314439 [details] Patch Let's definitely stop running all these files through the C preprocessor.
WebKit Commit Bot
Comment 5 2017-07-03 14:49:09 PDT
Comment on attachment 314439 [details] Patch Clearing flags on attachment: 314439 Committed r219097: <http://trac.webkit.org/changeset/219097>
WebKit Commit Bot
Comment 6 2017-07-03 14:49:10 PDT
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 7 2017-07-06 14:27:25 PDT Comment hidden (obsolete)
Sam Weinig
Comment 8 2017-07-06 14:27:25 PDT Comment hidden (obsolete)
Note You need to log in before you can comment on or make changes to this bug.