Bug 174071

Summary: Expose viewport-fit value to UIKit via viewport arguments dictionary
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, commit-queue, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2017-07-01 21:42:33 PDT
Expose viewport-fit value to UIKit via viewport arguments dictionary
Attachments
Patch (6.11 KB, patch)
2017-07-01 21:43 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (6.17 KB, patch)
2017-07-01 21:45 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-07-01 21:43:20 PDT
Created attachment 314400 [details] Patch
Radar WebKit Bug Importer
Comment 2 2017-07-01 21:43:57 PDT
<rdar://problem/33096620>
Tim Horton
Comment 3 2017-07-01 21:45:38 PDT
Created attachment 314401 [details] Patch
Build Bot
Comment 4 2017-07-01 21:46:37 PDT
Attachment 314401 [details] did not pass style-queue: ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:210: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:211: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:212: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:213: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:215: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Wenson Hsieh
Comment 5 2017-07-01 23:14:55 PDT
Comment on attachment 314401 [details] Patch r=me It's a bit strange that these are all in WebHistoryItem* files :/
Tim Horton
Comment 6 2017-07-01 23:18:44 PDT
(In reply to Wenson Hsieh from comment #5) > Comment on attachment 314401 [details] > Patch > > r=me > > It's a bit strange that these are all in WebHistoryItem* files :/ Only a bit?
WebKit Commit Bot
Comment 7 2017-07-01 23:48:05 PDT
Comment on attachment 314401 [details] Patch Clearing flags on attachment: 314401 Committed r219057: <http://trac.webkit.org/changeset/219057>
WebKit Commit Bot
Comment 8 2017-07-01 23:48:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.