Bug 174069

Summary: Add API test for all parts of WebKit1 API related to favicons
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit APIAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, buildbot, cdumez, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174073
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Brady Eidson 2017-07-01 17:52:31 PDT
Add API test for all parts of WebKit1 API related to favicons

WebIconDatabase itself is not API.

But there are some icon-related things that *are* API:
- WebView's "mainFrameIcon" property
- KVO observation of changes to that property
- WebFrameLoadDelegate's "- (void)webView:(WebView *)sender didReceiveIcon:(NSImage *)image forFrame:(WebFrame *)frame" method

Before we gut WebIconDatabase, we should have a test in place for all that API.
Comment 1 Brady Eidson 2017-07-01 17:59:37 PDT Comment hidden (obsolete)
Comment 2 Build Bot 2017-07-01 18:01:57 PDT Comment hidden (obsolete)
Comment 3 Brady Eidson 2017-07-01 20:08:49 PDT Comment hidden (obsolete)
Comment 4 Build Bot 2017-07-01 20:10:07 PDT Comment hidden (obsolete)
Comment 5 Brady Eidson 2017-07-01 20:11:52 PDT
Created attachment 314398 [details]
Patch
Comment 6 Andy Estes 2017-07-02 12:00:53 PDT
Comment on attachment 314398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314398&action=review

> Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:34
> +static bool messageReceived = false;

No = false
Comment 7 Brady Eidson 2017-07-02 12:10:59 PDT
(In reply to Andy Estes from comment #6)
> Comment on attachment 314398 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314398&action=review
> 
> > Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:34
> > +static bool messageReceived = false;
> 
> No = false

I'll loop back around and change that when I touch this test in my next patch
Comment 8 Brady Eidson 2017-07-02 12:12:07 PDT
(In bug 174073)
Comment 9 WebKit Commit Bot 2017-07-02 12:39:01 PDT
Comment on attachment 314398 [details]
Patch

Clearing flags on attachment: 314398

Committed r219059: <http://trac.webkit.org/changeset/219059>
Comment 10 WebKit Commit Bot 2017-07-02 12:39:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Brady Eidson 2017-07-02 17:14:21 PDT
Some bots aren't liking this test. Can't reproduce locally (Of course!)

I think I will resolve with https://bugs.webkit.org/show_bug.cgi?id=174073