Bug 174069

Summary:

Add API test for all parts of WebKit1 API related to favicons

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit API

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, buildbot, cdumez, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=174073

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Brady Eidson

Reported 2017-07-01 17:52:31 PDT

Add API test for all parts of WebKit1 API related to favicons WebIconDatabase itself is not API. But there are some icon-related things that *are* API: - WebView's "mainFrameIcon" property - KVO observation of changes to that property - WebFrameLoadDelegate's "- (void)webView:(WebView *)sender didReceiveIcon:(NSImage *)image forFrame:(WebFrame *)frame" method Before we gut WebIconDatabase, we should have a test in place for all that API.

Attachments
Patch (13.82 KB, patch) 2017-07-01 17:59 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (15.62 KB, patch) 2017-07-01 20:08 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (15.62 KB, patch) 2017-07-01 20:11 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-07-01 17:59:37 PDT Comment hidden (obsolete)

Created attachment 314394 [details] Patch

Build Bot

Comment 2 2017-07-01 18:01:57 PDT Comment hidden (obsolete)

Attachment 314394 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:120: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 3 2017-07-01 20:08:49 PDT Comment hidden (obsolete)

Created attachment 314397 [details] Patch

Build Bot

Comment 4 2017-07-01 20:10:07 PDT Comment hidden (obsolete)

Attachment 314397 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:186: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:227: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 5 2017-07-01 20:11:52 PDT

Created attachment 314398 [details] Patch

Andy Estes

Comment 6 2017-07-02 12:00:53 PDT

Comment on attachment 314398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314398&action=review > Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:34 > +static bool messageReceived = false; No = false

Brady Eidson

Comment 7 2017-07-02 12:10:59 PDT

(In reply to Andy Estes from comment #6) > Comment on attachment 314398 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314398&action=review > > > Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:34 > > +static bool messageReceived = false; > > No = false I'll loop back around and change that when I touch this test in my next patch

Brady Eidson

Comment 8 2017-07-02 12:12:07 PDT

(In bug 174073)

WebKit Commit Bot

Comment 9 2017-07-02 12:39:01 PDT

Comment on attachment 314398 [details] Patch Clearing flags on attachment: 314398 Committed r219059: <http://trac.webkit.org/changeset/219059>

WebKit Commit Bot

Comment 10 2017-07-02 12:39:02 PDT

All reviewed patches have been landed. Closing bug.

Brady Eidson

Comment 11 2017-07-02 17:14:21 PDT

Some bots aren't liking this test. Can't reproduce locally (Of course!) I think I will resolve with https://bugs.webkit.org/show_bug.cgi?id=174073

Note You need to log in before you can comment on or make changes to this bug.