| Summary: | When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
| Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, aestes, commit-queue, rniwa | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Brady Eidson
2017-06-30 13:16:43 PDT
Created attachment 314322 [details]
Patch v1
Comment on attachment 314322 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=314322&action=review > Source/WebKit2/ChangeLog:7 > + Could you describe what was causing the bug, and how you're fixing it? is it that we weren't sending AddWebsiteDataStore when creating a new network process? Comment on attachment 314322 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=314322&action=review r=me > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:199 > + // This time, reuse the same network process but still do a new websitedatastore, to make sure even an existing network process > + // gets the new datastore. No, the problem is described here. If we have a new WebsiteDataStore and an existing NetworkProcess, we need to tell it about the new WebsiteDataStore. Comment on attachment 314322 [details] Patch v1 Clearing flags on attachment: 314322 Committed r219052: <http://trac.webkit.org/changeset/219052> All reviewed patches have been landed. Closing bug. |