Bug 174035

Summary: When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, commit-queue, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Brady Eidson
Reported 2017-06-30 13:16:43 PDT
When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed When the networking process doesn't exist yet, and then the operation launches it, it doesn't know about the WebsiteDataStore.
Attachments
Patch v1 (9.32 KB, patch)
2017-06-30 16:47 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-06-30 13:17:21 PDT
<rdar://problem/32410662>
Brady Eidson
Comment 2 2017-06-30 16:47:00 PDT
Created attachment 314322 [details] Patch v1
Ryosuke Niwa
Comment 3 2017-06-30 21:33:14 PDT
Comment on attachment 314322 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=314322&action=review > Source/WebKit2/ChangeLog:7 > + Could you describe what was causing the bug, and how you're fixing it? is it that we weren't sending AddWebsiteDataStore when creating a new network process?
Alex Christensen
Comment 4 2017-06-30 23:40:37 PDT
Comment on attachment 314322 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=314322&action=review r=me > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:199 > + // This time, reuse the same network process but still do a new websitedatastore, to make sure even an existing network process > + // gets the new datastore. No, the problem is described here. If we have a new WebsiteDataStore and an existing NetworkProcess, we need to tell it about the new WebsiteDataStore.
WebKit Commit Bot
Comment 5 2017-07-01 14:37:57 PDT
Comment on attachment 314322 [details] Patch v1 Clearing flags on attachment: 314322 Committed r219052: <http://trac.webkit.org/changeset/219052>
WebKit Commit Bot
Comment 6 2017-07-01 14:37:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.