Bug 174024

Summary: Move make-js-file-arrays.py from WebCore to JavaScriptCore
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, joepeck, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172060
Attachments:
Description Flags
Patch
none
Try to fix mac builds
none
[PATCH] Mac Components
none
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-06-30 05:01:41 PDT
It's currently used only by WebCore, but it depends on other JavaScriptCore scripts and it's not WebCore specific at all. I plan to use it to compile the JavaScript atoms used by the WebDriver implementation.
Attachments
Patch (8.19 KB, patch)
2017-06-30 05:08 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Try to fix mac builds (8.18 KB, patch)
2017-06-30 07:02 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
[PATCH] Mac Components (5.07 KB, patch)
2017-06-30 18:31 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Patch (12.46 KB, patch)
2017-07-10 03:51 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-30 05:08:37 PDT
Created attachment 314259 [details] Patch
Carlos Garcia Campos
Comment 2 2017-06-30 07:02:42 PDT
Created attachment 314262 [details] Try to fix mac builds
Michael Catanzaro
Comment 3 2017-06-30 08:05:15 PDT
EWS is still red
Carlos Garcia Campos
Comment 4 2017-06-30 08:33:41 PDT
I don't know how to make this build in mac
Joseph Pecoraro
Comment 5 2017-06-30 18:31:17 PDT
(In reply to Carlos Garcia Campos from comment #4) > I don't know how to make this build in mac The Script to be included as a PrivateHeader in JavaScriptCore so that WebCore can inject it. Here let me try to do it.
Joseph Pecoraro
Comment 6 2017-06-30 18:31:34 PDT
Created attachment 314344 [details] [PATCH] Mac Components Try adding this to your patch.
Carlos Garcia Campos
Comment 7 2017-07-10 03:51:52 PDT
Created attachment 314972 [details] Patch Thanks Joe! let's try this now.
Carlos Garcia Campos
Comment 8 2017-07-10 06:20:07 PDT
Committed r219289: <http://trac.webkit.org/changeset/219289>
Note You need to log in before you can comment on or make changes to this bug.