Bug 174019

Summary: [WPE] Fontconfig build breaks with glibc 2.15+
Product: WebKit Reporter: Jacobo Aragunde Pérez <jaragunde>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: achristensen, bugs-noreply, cgarcia, clopez, commit-queue, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Jacobo Aragunde Pérez 2017-06-30 01:51:39 PDT
Fontconfig build breaks with glibc 2.15+
Comment 1 Jacobo Aragunde Pérez 2017-06-30 01:56:46 PDT
Created attachment 314249 [details]
Comment 2 Carlos Garcia Campos 2017-06-30 02:05:16 PDT
Is the patch included in a newer fontconfig release? I'm fine adding the patch, but maybe it's easier if we just bump fontconfig to a new version (checking the tests to ensure it doesn't affect the results)
Comment 3 Carlos Garcia Campos 2017-06-30 02:07:40 PDT
I guess we need the same in GTK+, no?
Comment 4 Jacobo Aragunde Pérez 2017-06-30 02:10:58 PDT
The patch was included in fontconfig 2.12.2 and we are currently using 2.11.1. Latest fontconfig release is 2.12.3.

I can try 2.12.3 and check if the version bump breaks something. I can also check the GTK+ build.
Comment 5 Carlos Garcia Campos 2017-06-30 02:18:11 PDT
Yes, I would definitely try to use 2.12.3 first. If it builds and test results are not affected (or it's just a matter of a simple rebaseline), it's simpler and better than adding another patch to maintain.
Comment 6 Jacobo Aragunde Pérez 2017-06-30 02:42:36 PDT
I've noticed the GTK+ fontconfig was already patched.
Comment 7 Carlos Alberto Lopez Perez 2017-06-30 05:51:13 PDT
Comment on attachment 314249 [details]

At some point we will want to share the common parts with the WebKitGTK+ moduleset

For the moment i think this is good enough, thanks for the patch.
Comment 8 WebKit Commit Bot 2017-06-30 06:18:43 PDT
Comment on attachment 314249 [details]

Clearing flags on attachment: 314249

Committed r218993: <http://trac.webkit.org/changeset/218993>
Comment 9 WebKit Commit Bot 2017-06-30 06:18:44 PDT
All reviewed patches have been landed.  Closing bug.