Summary: | [WPE] Fontconfig build breaks with glibc 2.15+ | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jacobo Aragunde Pérez <jaragunde> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bugs-noreply, cgarcia, clopez, commit-queue, zan | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jacobo Aragunde Pérez
2017-06-30 01:51:39 PDT
Created attachment 314249 [details]
Patch
Is the patch included in a newer fontconfig release? I'm fine adding the patch, but maybe it's easier if we just bump fontconfig to a new version (checking the tests to ensure it doesn't affect the results) I guess we need the same in GTK+, no? The patch was included in fontconfig 2.12.2 and we are currently using 2.11.1. Latest fontconfig release is 2.12.3. I can try 2.12.3 and check if the version bump breaks something. I can also check the GTK+ build. Yes, I would definitely try to use 2.12.3 first. If it builds and test results are not affected (or it's just a matter of a simple rebaseline), it's simpler and better than adding another patch to maintain. I've noticed the GTK+ fontconfig was already patched. Comment on attachment 314249 [details]
Patch
At some point we will want to share the common parts with the WebKitGTK+ moduleset
For the moment i think this is good enough, thanks for the patch.
Comment on attachment 314249 [details] Patch Clearing flags on attachment: 314249 Committed r218993: <http://trac.webkit.org/changeset/218993> All reviewed patches have been landed. Closing bug. |