Bug 173999

Summary: [PAL] Move Sound into PAL
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, don.olmstead, mcatanzaro, mmaxfield, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Ross Kirsling
Reported 2017-06-29 17:32:40 PDT
Move Sound.h to pal/system/Sound.h.
Attachments
Patch (38.86 KB, patch)
2017-06-29 18:09 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (45.41 KB, patch)
2017-06-29 21:00 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (45.48 KB, patch)
2017-06-29 21:47 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (45.48 KB, patch)
2017-06-29 22:06 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2017-06-29 18:09:32 PDT
Created attachment 314197 [details] Patch
Ross Kirsling
Comment 2 2017-06-29 21:00:49 PDT
Created attachment 314223 [details] Patch
Ross Kirsling
Comment 3 2017-06-29 21:47:03 PDT
Created attachment 314228 [details] Patch
Ross Kirsling
Comment 4 2017-06-29 22:06:24 PDT
Created attachment 314234 [details] Patch
WebKit Commit Bot
Comment 5 2017-06-30 09:12:21 PDT
Comment on attachment 314234 [details] Patch Clearing flags on attachment: 314234 Committed r218999: <http://trac.webkit.org/changeset/218999>
WebKit Commit Bot
Comment 6 2017-06-30 09:12:23 PDT
All reviewed patches have been landed. Closing bug.
Tim Horton
Comment 7 2017-08-14 14:03:49 PDT
No, we should be /able/ to build without the prefix header, it’s just about build time optimization. See the commment at the top of the file.
Tim Horton
Comment 8 2017-08-14 14:04:12 PDT
Uhh, wrong bug
Note You need to log in before you can comment on or make changes to this bug.