Bug 173993

Summary: [WebIDL] Add support for conditionally read-write attributes
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Sam Weinig 2017-06-29 16:39:47 PDT 
[WebIDL] Add support for conditionally read-write attributes
Comment 1 Sam Weinig 2017-06-29 16:46:15 PDT 
Created attachment 314184 [details]
Patch
Comment 2 Alex Christensen 2017-06-30 08:51:36 PDT 
Comment on attachment 314184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314184&action=review

> Source/WebCore/bindings/scripts/test/TestObj.idl:455
> +    [Conditional=CONDITION2, ConditionallyReadWrite=CONDITION] attribute Node conditionalAndConditionallyReadWriteAttribute;

This test could be more clear if CONDITION were CONDITION3
Comment 3 Sam Weinig 2017-06-30 11:37:56 PDT 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 314184 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314184&action=review
> 
> > Source/WebCore/bindings/scripts/test/TestObj.idl:455
> > +    [Conditional=CONDITION2, ConditionallyReadWrite=CONDITION] attribute Node conditionalAndConditionallyReadWriteAttribute;
> 
> This test could be more clear if CONDITION were CONDITION3

I'll update it to be even more clear. Something like GENERAL_CONDITION and READ_WRITE_CONDITION.
Comment 4 WebKit Commit Bot 2017-06-30 12:05:00 PDT 
Comment on attachment 314184 [details]
Patch

Clearing flags on attachment: 314184

Committed r219007: <http://trac.webkit.org/changeset/219007>
Comment 5 WebKit Commit Bot 2017-06-30 12:05:01 PDT 
All reviewed patches have been landed.  Closing bug.