RESOLVED FIXED Bug 173993
[WebIDL] Add support for conditionally read-write attributes 
https://bugs.webkit.org/show_bug.cgi?id=173993
Summary [WebIDL] Add support for conditionally read-write attributes
Sam Weinig
Reported 2017-06-29 16:39:47 PDT
[WebIDL] Add support for conditionally read-write attributes
Attachments
Patch (29.69 KB, patch)
2017-06-29 16:46 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-06-29 16:46:15 PDT
Created attachment 314184 [details] Patch
Alex Christensen
Comment 2 2017-06-30 08:51:36 PDT
Comment on attachment 314184 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314184&action=review > Source/WebCore/bindings/scripts/test/TestObj.idl:455 > + [Conditional=CONDITION2, ConditionallyReadWrite=CONDITION] attribute Node conditionalAndConditionallyReadWriteAttribute; This test could be more clear if CONDITION were CONDITION3
Sam Weinig
Comment 3 2017-06-30 11:37:56 PDT
(In reply to Alex Christensen from comment #2) > Comment on attachment 314184 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314184&action=review > > > Source/WebCore/bindings/scripts/test/TestObj.idl:455 > > + [Conditional=CONDITION2, ConditionallyReadWrite=CONDITION] attribute Node conditionalAndConditionallyReadWriteAttribute; > > This test could be more clear if CONDITION were CONDITION3 I'll update it to be even more clear. Something like GENERAL_CONDITION and READ_WRITE_CONDITION.
WebKit Commit Bot
Comment 4 2017-06-30 12:05:00 PDT
Comment on attachment 314184 [details] Patch Clearing flags on attachment: 314184 Committed r219007: <http://trac.webkit.org/changeset/219007>
WebKit Commit Bot
Comment 5 2017-06-30 12:05:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.