Bug 173993 - [WebIDL] Add support for conditionally read-write attributes
Summary: [WebIDL] Add support for conditionally read-write attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-29 16:39 PDT by Sam Weinig
Modified: 2017-06-30 12:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch (29.69 KB, patch)
2017-06-29 16:46 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-06-29 16:39:47 PDT 
[WebIDL] Add support for conditionally read-write attributes
Comment 1 Sam Weinig 2017-06-29 16:46:15 PDT 
Created attachment 314184 [details]
Patch
Comment 2 Alex Christensen 2017-06-30 08:51:36 PDT 
Comment on attachment 314184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314184&action=review

> Source/WebCore/bindings/scripts/test/TestObj.idl:455
> +    [Conditional=CONDITION2, ConditionallyReadWrite=CONDITION] attribute Node conditionalAndConditionallyReadWriteAttribute;

This test could be more clear if CONDITION were CONDITION3
Comment 3 Sam Weinig 2017-06-30 11:37:56 PDT 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 314184 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314184&action=review
> 
> > Source/WebCore/bindings/scripts/test/TestObj.idl:455
> > +    [Conditional=CONDITION2, ConditionallyReadWrite=CONDITION] attribute Node conditionalAndConditionallyReadWriteAttribute;
> 
> This test could be more clear if CONDITION were CONDITION3

I'll update it to be even more clear. Something like GENERAL_CONDITION and READ_WRITE_CONDITION.
Comment 4 WebKit Commit Bot 2017-06-30 12:05:00 PDT 
Comment on attachment 314184 [details]
Patch

Clearing flags on attachment: 314184

Committed r219007: <http://trac.webkit.org/changeset/219007>
Comment 5 WebKit Commit Bot 2017-06-30 12:05:01 PDT 
All reviewed patches have been landed.  Closing bug.