Bug 173985

Summary: Web Inspector: Cleanup unused/invalid parameters for SidebarPanels
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173807
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2017-06-29 12:53:50 PDT
Now that we have shifted to using WebInspector.instanceForClass, any object that is constructed via that function will never have values passed to it's constructor. We should remove/cleanup any parameters that are still listed.
Attachments
Patch (13.27 KB, patch)
2017-06-29 14:30 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-06-29 14:30:20 PDT
Created attachment 314168 [details] Patch
Joseph Pecoraro
Comment 2 2017-06-29 17:13:01 PDT
Comment on attachment 314168 [details] Patch r=me
WebKit Commit Bot
Comment 3 2017-06-29 17:41:07 PDT
Comment on attachment 314168 [details] Patch Clearing flags on attachment: 314168 Committed r218975: <http://trac.webkit.org/changeset/218975>
WebKit Commit Bot
Comment 4 2017-06-29 17:41:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.