Summary: | Slight clean up of WebResourceLoadStatisticsStore | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, ggaren, sam, wilander | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2017-06-29 10:53:51 PDT
Created attachment 314143 [details]
Patch
Created attachment 314145 [details]
Patch
Comment on attachment 314145 [details]
Patch
r=me. I'm not sure why the WPE bot is red though. Doesn't seem like your changes should have affected it.
(In reply to Brent Fulgham from comment #3) > Comment on attachment 314145 [details] > Patch > > r=me. I'm not sure why the WPE bot is red though. Doesn't seem like your > changes should have affected it. ource/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebResourceLoadStatisticsStore.cpp.o.d -o Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebResourceLoadStatisticsStore.cpp.o -c /home/ews/igalia-wpe-ews/WebKit/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp /home/ews/igalia-wpe-ews/WebKit/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp: In function 'const WTF::OptionSet<WebKit::WebsiteDataType>& WebKit::dataTypesToRemove()': /home/ews/igalia-wpe-ews/WebKit/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:62:103: error: variable 'WTF::NeverDestroyed<WTF::OptionSet<WebKit::WebsiteDataType> > dataTypes' has initializer but incomplete type Will fix before landing. Created attachment 314148 [details]
Patch
Comment on attachment 314148 [details] Patch Clearing flags on attachment: 314148 Committed r218958: <http://trac.webkit.org/changeset/218958> All reviewed patches have been landed. Closing bug. |