Bug 173973

Summary: Make InlineBox::m_topLeft and m_logicalWidth protected.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

alan
Reported 2017-06-29 10:24:49 PDT
Why are they public!
Attachments
Patch (2.28 KB, patch)
2017-06-29 10:35 PDT, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2017-06-29 10:25:21 PDT
lol https://trac.webkit.org/browser/webkit/trunk/WebCore/rendering/InlineBox.h?rev=21249 // FIXME: Would like to make this protected, but methods are accessing these members over in the part.
alan
Comment 2 2017-06-29 10:35:20 PDT
Created attachment 314141 [details] Patch
WebKit Commit Bot
Comment 3 2017-06-29 11:47:28 PDT
Comment on attachment 314141 [details] Patch Clearing flags on attachment: 314141 Committed r218950: <http://trac.webkit.org/changeset/218950>
WebKit Commit Bot
Comment 4 2017-06-29 11:47:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.