Bug 17397

Summary: REGRESSION (r30236-30336): Cannot backspace/enter in forms on Windows
Product: WebKit Reporter: Matt Lilek <dev+webkit>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: ap
Priority: P1 Keywords: InRadar, PlatformOnly, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: data:text/html,<input type="text" value="I CAN HAS BACKSPACE?">
Attachments:
Description Flags
proposed fix (untested) darin: review+

Matt Lilek
Reported 2008-02-16 17:21:59 PST
Backspace, enter, paste, etc are all broken in the address bar and search box in Safari on Windows. This extends to standard form controls as well - loading the above HTML snippet and pressing backspace after focusing the input causes the previous page to be loaded.
Attachments
proposed fix (untested) (5.74 KB, patch)
2008-02-17 00:03 PST, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2008-02-16 18:35:26 PST
<rdar://problem/5748245>
Alexey Proskuryakov
Comment 2 2008-02-16 23:38:17 PST
This is caused by mismatching ENABLE_CROSS_DOCUMENT_MESSAGING macros between WebKit and WebCore projects. This problem was supposed to be fixed in r30276, but apparently some configurations remained wrong.
Alexey Proskuryakov
Comment 3 2008-02-16 23:40:32 PST
Um, not r30276 - that was a Mac-only change. Anyway, this was supposed to be fixed :)
Alexey Proskuryakov
Comment 4 2008-02-17 00:03:07 PST
Created attachment 19169 [details] proposed fix (untested) My build isn't finished yet, and I have to leave for a day, but this should fix the problem.
Darin Adler
Comment 5 2008-02-17 07:26:38 PST
Comment on attachment 19169 [details] proposed fix (untested) r=me
Alexey Proskuryakov
Comment 6 2008-02-17 12:23:23 PST
Committed revision 30358 (with fingers crossed, as I haven't built yet).
Matt Lilek
Comment 7 2008-02-17 15:20:35 PST
(In reply to comment #6) > Committed revision 30358 (with fingers crossed, as I haven't built yet). > It works :)
Note You need to log in before you can comment on or make changes to this bug.