Bug 173967

Summary: REGRESSION(r215347): NAS4Free Pop-down menus fail to appear
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: bfulgham, commit-queue, kling, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
kling: review+
patch none

Description Antti Koivisto 2017-06-29 06:24:35 PDT
Visibility change on non-composited layer should trigger layer geometry update.
Comment 1 Antti Koivisto 2017-06-29 06:25:07 PDT
Comment 2 Antti Koivisto 2017-06-29 06:33:39 PDT
Created attachment 314130 [details]
Comment 3 Andreas Kling 2017-06-29 06:42:55 PDT
Comment on attachment 314130 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=314130&action=review


> Source/WebCore/ChangeLog:3
> +        NAS4Free Pop-down menus take 3 seconds to appear

Maybe you could tell us a bit more about this? Since you brought it up, I mean.. If you hadn't, I would have accepted the patch as-is.

> Source/WebCore/ChangeLog:16
> +            Trigger compositing update for non-composited layers on visibility change.

Like you suggested on IRC, it would be nice to factor these checks out into a helper function.
Comment 4 Antti Koivisto 2017-06-29 07:02:09 PDT
Created attachment 314132 [details]
Comment 5 Simon Fraser (smfr) 2017-06-29 08:15:09 PDT
Comment on attachment 314132 [details]

Looks OK.
Comment 6 WebKit Commit Bot 2017-06-29 09:10:14 PDT
Comment on attachment 314132 [details]

Clearing flags on attachment: 314132

Committed r218925: <http://trac.webkit.org/changeset/218925>
Comment 7 WebKit Commit Bot 2017-06-29 09:10:16 PDT
All reviewed patches have been landed.  Closing bug.