Bug 173953

Summary: [ResourceLoadStatistics] Simplify PrevalentResourceTelemetry struct
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, dbates, japhet, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-06-28 19:35:20 PDT
Simplify PrevalentResourceTelemetry struct.
Attachments
Patch (5.18 KB, patch)
2017-06-28 19:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.27 KB, patch)
2017-06-28 20:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.95 KB, patch)
2017-06-28 21:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-06-28 19:36:35 PDT
Created attachment 314091 [details] Patch
Chris Dumez
Comment 2 2017-06-28 20:30:37 PDT
Oh Windows... C:\cygwin\home\buildbot\WebKit\Source\WebCore\loader\ResourceLoadStatisticsStore.cpp(396): error C2664: 'void WTF::Vector<WebCore::PrevalentResourceTelemetry,0,WTF::CrashOnOverflow,16>::append(WebCore::PrevalentResourceTelemetry &&)': cannot convert argument 1 from 'initializer list' to 'WebCore::PrevalentResourceTelemetry &&' [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\WebKit\Source\WebCore\loader\ResourceLoadStatisticsStore.cpp(396): note: Reason: cannot convert from 'initializer list' to 'WebCore::PrevalentResourceTelemetry' C:\cygwin\home\buildbot\WebKit\Source\WebCore\loader\ResourceLoadStatisticsStore.cpp(396): note: No constructor could take the source type, or constructor overload resolution was ambiguous
Chris Dumez
Comment 3 2017-06-28 20:31:45 PDT
Created attachment 314103 [details] Patch
Chris Dumez
Comment 4 2017-06-28 20:57:15 PDT
Comment on attachment 314103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314103&action=review > Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:389 > + sorted.append(PrevalentResourceTelemetry { Even with an explicit PrevalentResourceTelemetry { } Windows... C:\cygwin\home\buildbot\WebKit\Source\WebCore\loader\ResourceLoadStatisticsStore.cpp(396): error C2440: 'initializing': cannot convert from 'initializer list' to 'WebCore::PrevalentResourceTelemetry' [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\WebKit\Source\WebCore\loader\ResourceLoadStatisticsStore.cpp(396): note: No constructor could take the source type, or constructor overload resolution was ambiguous Generate bindings (WebCoreTestSupportBindings)
Chris Dumez
Comment 5 2017-06-28 21:02:52 PDT
Created attachment 314108 [details] Patch
WebKit Commit Bot
Comment 6 2017-06-28 22:43:08 PDT
Comment on attachment 314108 [details] Patch Clearing flags on attachment: 314108 Committed r218918: <http://trac.webkit.org/changeset/218918>
WebKit Commit Bot
Comment 7 2017-06-28 22:43:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.