Bug 173951

Summary: Avoid copying statistics in ResourceLoadStatisticsStore::readDataFromDecoder()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, dbates, ggaren, japhet, rniwa, wilander
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Chris Dumez
Reported 2017-06-28 19:21:38 PDT
Avoid copying statistics in ResourceLoadStatisticsStore::readDataFromDecoder().
Attachments
Patch (1.51 KB, patch)
2017-06-28 19:22 PDT, Chris Dumez 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-06-28 19:22:12 PDT
Created attachment 314090 [details] Patch
Ryosuke Niwa
Comment 2 2017-06-28 20:18:21 PDT
Comment on attachment 314090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314090&action=review > Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:141 > } > } Can we fix the indentation here?
Chris Dumez
Comment 3 2017-06-28 20:23:56 PDT
Comment on attachment 314090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314090&action=review >> Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:141 >> } > > Can we fix the indentation here? This is the end of the block for a Locker. Do we usually indent those?
Chris Dumez
Comment 4 2017-06-28 20:28:53 PDT
Committed r218912: <http://trac.webkit.org/changeset/218912>
Ryosuke Niwa
Comment 5 2017-06-28 20:37:38 PDT
(In reply to Chris Dumez from comment #3) > Comment on attachment 314090 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314090&action=review > > >> Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:141 > >> } > > > > Can we fix the indentation here? > > This is the end of the block for a Locker. Do we usually indent those? Yeah, we do. Each block should be indented.
Note You need to log in before you can comment on or make changes to this bug.