Bug 173942

Summary: WebsiteDataRecords for credential data don't have displayName set
Product: WebKit Reporter: Ansh Shukla <ansh_shukla>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: beidson, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch v1
none
patch v1 beidson: review+

Ansh Shukla
Reported 2017-06-28 15:41:58 PDT
In Bug 171217 (https://bugs.webkit.org/show_bug.cgi?id=171217), we started surfacing website data records of type _WKWebsiteDataTypeCredentials to represent HTTP authentication state. However, the WebsiteDataRecord objects for those HTTP credentials have nil displayName. This is required for Safari to properly surface this data in UI.
Attachments
patch v1 (29.36 KB, application/mbox)
2017-06-30 16:20 PDT, Ansh Shukla 		no flags
Details
patch v1 (25.61 KB, patch)
2017-06-30 16:26 PDT, Ansh Shukla 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ansh Shukla
Comment 1 2017-06-30 16:20:01 PDT
Created attachment 314313 [details] patch v1
Ansh Shukla
Comment 2 2017-06-30 16:26:04 PDT
Created attachment 314316 [details] patch v1
Brady Eidson
Comment 3 2017-06-30 16:51:00 PDT
Comment on attachment 314316 [details] patch v1 👍
Radar WebKit Bug Importer
Comment 4 2017-07-04 04:32:06 PDT
<rdar://problem/33122079>
Maciej Stachowiak
Comment 5 2020-05-30 19:14:01 PDT
Comment on attachment 314313 [details] patch v1 Uflagging, it seems like the patch was accidentally submitted twice.
Maciej Stachowiak
Comment 6 2020-05-30 19:14:23 PDT
This has been reviewed but seemingly not landed. Is it still good to go?
Maciej Stachowiak
Comment 7 2020-05-30 19:30:46 PDT
(Unfortunately, it seems the patch no longer applies, so it will need to be updated.)
Note You need to log in before you can comment on or make changes to this bug.