Bug 173921

Summary: [cmake] Improve configuration tests for librt and libatomic
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, buildbot, cgarcia, commit-queue, lforschler, mcatanzaro, tpopela
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2017-06-28 06:44:22 PDT
* Both tests are converted to use specialized CMake modules * Both libraries are now linked only if they are really needed and usable by compiler * librt is no more required to be detected by find_library(), which may fail in case of cross-compilation * librt test moved to port-independent CMakeLists.txt
Attachments
Patch (3.51 KB, patch)
2017-06-28 06:52 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (3.52 KB, patch)
2017-06-28 07:02 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2017-06-28 06:52:07 PDT
Created attachment 314018 [details] Patch
Build Bot
Comment 2 2017-06-28 06:53:39 PDT
Attachment 314018 [details] did not pass style-queue: ERROR: Source/WebKit2/CMakeLists.txt:724: Alphabetical sorting problem. """ should be before "int main() { std::atomic<int64_t> i(0); i++; return 0; }". [list/order] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Konstantin Tokarev
Comment 3 2017-06-28 07:02:43 PDT
Created attachment 314021 [details] Patch
Build Bot
Comment 4 2017-06-28 07:05:12 PDT
Attachment 314021 [details] did not pass style-queue: ERROR: Source/WebKit2/CMakeLists.txt:724: Alphabetical sorting problem. """ should be before "int main() { std::atomic<int64_t> i(0); i++; return 0; }". [list/order] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 5 2017-06-28 13:02:10 PDT
Comment on attachment 314021 [details] Patch Clearing flags on attachment: 314021 Committed r218888: <http://trac.webkit.org/changeset/218888>
WebKit Commit Bot
Comment 6 2017-06-28 13:02:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.