Bug 173921

Summary:

[cmake] Improve configuration tests for librt and libatomic

Product:

WebKit

Reporter:

Konstantin Tokarev <annulen>

Component:

Tools / Tests

Assignee:

Konstantin Tokarev <annulen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, buildbot, cgarcia, commit-queue, lforschler, mcatanzaro, tpopela

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Konstantin Tokarev 2017-06-28 06:44:22 PDT

* Both tests are converted to use specialized CMake modules
* Both libraries are now linked only if they are really needed and usable
  by compiler
* librt is no more required to be detected by find_library(), which may fail
  in case of cross-compilation
* librt test moved to port-independent CMakeLists.txt

Comment 1 Konstantin Tokarev 2017-06-28 06:52:07 PDT

Created attachment 314018 [details]
Patch

Comment 2 Build Bot 2017-06-28 06:53:39 PDT

Attachment 314018 [details] did not pass style-queue:


ERROR: Source/WebKit2/CMakeLists.txt:724:  Alphabetical sorting problem. """ should be before "int main() { std::atomic<int64_t> i(0); i++; return 0; }".  [list/order] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Konstantin Tokarev 2017-06-28 07:02:43 PDT

Created attachment 314021 [details]
Patch

Comment 4 Build Bot 2017-06-28 07:05:12 PDT

Attachment 314021 [details] did not pass style-queue:


ERROR: Source/WebKit2/CMakeLists.txt:724:  Alphabetical sorting problem. """ should be before "int main() { std::atomic<int64_t> i(0); i++; return 0; }".  [list/order] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 WebKit Commit Bot 2017-06-28 13:02:10 PDT

Comment on attachment 314021 [details]
Patch

Clearing flags on attachment: 314021

Committed r218888: <http://trac.webkit.org/changeset/218888>

Comment 6 WebKit Commit Bot 2017-06-28 13:02:12 PDT

All reviewed patches have been landed.  Closing bug.