Bug 173906

Summary: JITStubRoutine::passesFilter should use isJITPC
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, ticaiolima, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
jfbastien: review+
patch for landing
saam: commit-queue-
patch for landing none

Description Saam Barati 2017-06-27 22:24:53 PDT 
...
Comment 1 Saam Barati 2017-06-27 22:36:08 PDT 
Created attachment 313991 [details]
patch
Comment 2 JF Bastien 2017-06-27 22:38:35 PDT 
Comment on attachment 313991 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313991&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        inside ExecutableAllocator.h. Before, JITStubRoutine would was using

"would was"
Comment 3 Mark Lam 2017-06-27 22:40:03 PDT 
Comment on attachment 313991 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313991&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        the harcoded platform size constant. This means it'd do the wrong thing

typo: /the harcoded/a hardcoded/.

> Source/JavaScriptCore/ChangeLog:12
> +        constant for that platform. This patch also removes up a bunch of

delete "up".
Comment 4 Saam Barati 2017-06-27 22:41:00 PDT 
Created attachment 313993 [details]
patch for landing
Comment 5 Saam Barati 2017-06-27 22:43:12 PDT 
Created attachment 313994 [details]
patch for landing
Comment 6 WebKit Commit Bot 2017-06-27 23:23:27 PDT 
Comment on attachment 313994 [details]
patch for landing

Clearing flags on attachment: 313994

Committed r218867: <http://trac.webkit.org/changeset/218867>
Comment 7 WebKit Commit Bot 2017-06-27 23:23:28 PDT 
All reviewed patches have been landed.  Closing bug.