Bug 173888

Summary:

[JSC] Do not touch VM after notifying Ready in DFG::Worklist

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, fpizlo, keith_miller, mark.lam, msaboff, ryanhaddad, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	saam: review+

Description Yusuke Suzuki 2017-06-27 14:25:39 PDT

[JSC] Do not touch VM after notifying Ready in DFG::Worklist

Comment 1 Yusuke Suzuki 2017-06-27 14:28:36 PDT

Created attachment 313944 [details]
Patch

Comment 2 Build Bot 2017-06-27 14:31:48 PDT

Attachment 313944 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:9:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: dangling pointer  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Yusuke Suzuki 2017-06-27 14:33:42 PDT

Created attachment 313947 [details]
Patch

Comment 4 Saam Barati 2017-06-27 14:41:57 PDT

Can you unmark the test as flaky too?

Comment 5 Yusuke Suzuki 2017-06-27 17:43:05 PDT

(In reply to Saam Barati from comment #4)
> Can you unmark the test as flaky too?

Sure!

Comment 6 Yusuke Suzuki 2017-06-27 17:45:26 PDT

(In reply to Yusuke Suzuki from comment #5)
> (In reply to Saam Barati from comment #4)
> > Can you unmark the test as flaky too?
> 
> Sure!

It seems that existing test marking is just Slow due to its slowness.

Comment 7 Yusuke Suzuki 2017-06-27 17:46:54 PDT

Committed r218856: <http://trac.webkit.org/changeset/218856>