Bug 173888 - [JSC] Do not touch VM after notifying Ready in DFG::Worklist
Summary: [JSC] Do not touch VM after notifying Ready in DFG::Worklist
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-27 14:25 PDT by Yusuke Suzuki
Modified: 2017-06-27 17:46 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2017-06-27 14:28 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2017-06-27 14:33 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-06-27 14:25:39 PDT 
[JSC] Do not touch VM after notifying Ready in DFG::Worklist
Comment 1 Yusuke Suzuki 2017-06-27 14:28:36 PDT 
Created attachment 313944 [details]
Patch
Comment 2 Build Bot 2017-06-27 14:31:48 PDT 
Attachment 313944 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:9:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: dangling pointer  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2017-06-27 14:33:42 PDT 
Created attachment 313947 [details]
Patch
Comment 4 Saam Barati 2017-06-27 14:41:57 PDT 
Can you unmark the test as flaky too?
Comment 5 Yusuke Suzuki 2017-06-27 17:43:05 PDT 
(In reply to Saam Barati from comment #4)
> Can you unmark the test as flaky too?

Sure!
Comment 6 Yusuke Suzuki 2017-06-27 17:45:26 PDT 
(In reply to Yusuke Suzuki from comment #5)
> (In reply to Saam Barati from comment #4)
> > Can you unmark the test as flaky too?
> 
> Sure!

It seems that existing test marking is just Slow due to its slowness.
Comment 7 Yusuke Suzuki 2017-06-27 17:46:54 PDT 
Committed r218856: <http://trac.webkit.org/changeset/218856>