Bug 173885

Summary: Web Inspector: Cleanup RemoteObject tests
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix mattbaker: review+

Joseph Pecoraro
Reported 2017-06-27 13:58:42 PDT
Following some cleanup on RemoteObject tests after the recent changes. • Fix a bug causing a test to timeout • Separate out DOM specific objects which differ across platforms • One expectation file for all core JavaScript object values • Update syntax to use template strings as they are much better for code
Attachments
[PATCH] Proposed Fix (156.25 KB, patch)
2017-06-27 14:01 PDT, Joseph Pecoraro 		mattbaker: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-06-27 14:01:11 PDT
Created attachment 313937 [details] [PATCH] Proposed Fix
Matt Baker
Comment 2 2017-06-27 14:10:40 PDT
Comment on attachment 313937 [details] [PATCH] Proposed Fix r=me
Joseph Pecoraro
Comment 3 2017-06-27 21:24:18 PDT
<https://trac.webkit.org/r218862>
Note You need to log in before you can comment on or make changes to this bug.